Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

serializers: bibtex: Conference paper not falling back to proceedings #1917

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

serializers: bibtex: Conference paper not falling back to proceedings #1917

wants to merge 1 commit into from

Conversation

ptamarit
Copy link
Member

❤️ Thank you for your contribution!

Description

Checklist

Ticks in all boxes and 🟢 on all GitHub actions status checks are required to merge:

Frontend

Reminder

By using GitHub, you have already agreed to the GitHub’s Terms of Service including that:

  1. You license your contribution under the same terms as the current repository’s license.
  2. You agree that you have the right to license your contribution under the current repository’s license.

ptamarit
ptamarit commented Dec 17, 2024
View reviewed changes
tests/resources/serializers/test_bibtex_serializer.py
del updated_minimal_record["custom_fields"]["imprint:imprint"]
serialized_record = serializer.serialize_object(updated_minimal_record)

expected_data = "\n".join(
[
"@proceedings{brown_2023_abcde-fghij,",
"@misc{brown_2023_abcde-fghij,",
" author = {Name and",
" Troy Inc.},",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note the this part of the test did NOT have an assertion, and that the expected data was not correct (proceedings do NOT have an author).

tmorrell
tmorrell approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@tmorrell tmorrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This makes sense! I think a conference proceedings without a title is best mapped to misc. If we add publication-conferenceproceeding that's really the correct mapping and then we don't lose anything.

invenio_rdm_records/resources/serializers/bibtex/schema.py Outdated Show resolved Hide resolved
@tmorrell
Copy link
Contributor

Ah, you already did that #1915. All good to go

@ptamarit ptamarit force-pushed the 1916-bibtex-conference-paper-no-proceedings-fallback branch from a88d2f4 to 288af91 Compare December 18, 2024 09:22
@ptamarit
Copy link
Member Author

Just reformatted the code to appear on one line.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmorrell tmorrell tmorrell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Resource type "Publication / Conference paper" should not fall back to BibTeX type "proceedings"
2 participants
@ptamarit @tmorrell